Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back GEDGsfElectronFinalizer to be a stream module, instead of a global one #28853

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Bring back GEDGsfElectronFinalizer to be a stream module, instead of a global one #28853

merged 1 commit into from
Feb 3, 2020

Conversation

perrotta
Copy link
Contributor

@perrotta perrotta commented Feb 2, 2020

As noticed in the github issue #28849, when #28746 GEDGsfElectronFinalizer was changed from a stream module to a global module that broke thread safety.
This PR brings back the GEDGsfElectronFinalizer to be a stream module, instead of a global one

PR validation:

It runs in the short matrix

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone Feb 2, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2020

The code-checks are being triggered in jenkins.

@perrotta perrotta mentioned this pull request Feb 2, 2020
Closed
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28853/13603

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2020

A new Pull Request was created by @perrotta for master.

It involves the following packages:

RecoEgamma/EgammaElectronProducers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @rovere, @lgray, @sobhatta, @afiqaize, @varuns23 this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

perrotta commented Feb 2, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2020 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4461/console Started: 2020/02/02 19:18

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2020

+1
Tested at: d455c7c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-adc3fc/4461/summary.html
CMSSW: CMSSW_11_1_X_2020-02-02-0000
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-adc3fc/4461/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697068
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2696721
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@perrotta
Copy link
Contributor Author

perrotta commented Feb 2, 2020

+1

  • Fix: GEDGsfElectronFinalizer made to be a stream module
  • Jenkins tests pass

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 60e4c46 into cms-sw:master Feb 3, 2020
@perrotta perrotta deleted the putBackGEDGsfElectronFinalizerAsStreamModule branch February 3, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed orp-approved reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.
3 participants
@perrotta @cmsbuild @silviodonato